Skip to content

Change default current device to None #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

Change default current device to None #39

merged 1 commit into from
Sep 22, 2020

Conversation

1e-to
Copy link
Contributor

@1e-to 1e-to commented Sep 18, 2020

No description provided.

@PokhodenkoSA
Copy link
Contributor

@1e-to could you give a description for the changes please?

@1e-to
Copy link
Contributor Author

1e-to commented Sep 18, 2020

This PR related to adding semantics to Numba-dppl.
The current device value changed to None when we are not inside any dppl.device_context, and is only set the first time we enter the with scope.

@diptorupd
Copy link
Contributor

@1e-to can you review the new dppl API dppl/sycl_core.pyx? dppl.get_current_queue always returns a queue, but I have a is_in_dppl_ctxt function that checks if we are inside a with context. Will that work for the new dispatcher in Numba?

@PokhodenkoSA PokhodenkoSA merged commit e590884 into master Sep 22, 2020
@PokhodenkoSA PokhodenkoSA mentioned this pull request Sep 23, 2020
Merged
@diptorupd diptorupd deleted the feature/curr_device branch February 26, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@1e-to @PokhodenkoSA @diptorupd